Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rename allowedPostUpgradeCommands/allowPostUpgradeCommandTemplating #32657

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Nov 21, 2024

Changes

Rename allowedPostUpgradeCommands to allowedCommands

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins requested a review from viceice November 21, 2024 14:32
@rarkins rarkins marked this pull request as draft November 21, 2024 14:40
@rarkins rarkins changed the title feat: rename allowedPostUpgradeCommands to allowedCommands feat: rename allowedPostUpgradeCommands/allowPostUpgradeCommandTemplating Nov 21, 2024
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need a rename migration? Otherwise LGTM

@rarkins rarkins marked this pull request as ready for review November 21, 2024 15:04
@rarkins
Copy link
Collaborator Author

rarkins commented Nov 21, 2024

Yes, needs some testing on a real repo too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants