Dns refactory #130
Dns refactory #130
Conversation
3-networks-hub-and-spoke/envs/shared/partner_interconnect.tf.example
Outdated
Show resolved
Hide resolved
| module.dns_hub_vpc.network_self_link | ||
| ] | ||
| target_name_server_addresses = data.google_compute_network.vpc_dns_hub.self_link | ||
| } |
There was a problem hiding this comment.
missing empty line at the end of file
| advertised_ip_ranges = [{ range = local.private_googleapis_cidr }] | ||
| advertised_ip_ranges = [ | ||
| { range = local.private_googleapis_cidr }, | ||
| { range = "35.199.192.0/19" } |
There was a problem hiding this comment.
{ range = "35.199.192.0/19" } is conditional on the network being the one that will access the dns server in the on-prem infrastructure
| advertised_ip_ranges = [{ range = local.restricted_googleapis_cidr }] | ||
| advertised_ip_ranges = [ | ||
| { range = local.restricted_googleapis_cidr }, | ||
| { range = "35.199.192.0/19" } |
There was a problem hiding this comment.
{ range = "35.199.192.0/19" } is conditional on the network being the one that will access the dns server in the on-prem infrastructure
| advertised_ip_ranges = concat( | ||
| [{ range = local.private_googleapis_cidr }], | ||
| var.private_service_cidr != null ? [{ range = "35.199.192.0/19" }] : [] | ||
| ) |
There was a problem hiding this comment.
this is the same value for each router.
this could be on a local
renato-rudnicki
force-pushed
the
dns-refactory
branch
from
02decb3 to
573bdf4
Compare
renato-rudnicki
force-pushed
the
review-dns-refactory
branch
2 times, most recently
from
2ab1b6e to
f7c4d14
Compare
There was a problem hiding this comment.
in the 3-networks-hub-and-spoke case the variable target_name_server_addresses is only used in the shared environment, so it does not need to exist in dev/nonprod/prod
changes:
- in the
base_envit should have an empty value default so that it would not be required - it should ne removed from dev/nonprod/prod
| @@ -126,7 +127,7 @@ module "region1_router1" { | |||
| bgp = { | |||
| asn = var.bgp_asn_subnet | |||
| advertised_groups = ["ALL_SUBNETS"] | |||
| advertised_ip_ranges = [{ range = local.private_googleapis_cidr }] | |||
| advertised_ip_ranges = var.private_service_cidr == null ? [{ range = local.google_private_service_range }] : [{ range = local.private_googleapis_cidr }] | |||
There was a problem hiding this comment.
this should be in a local since it is duplicated 4 times
| @@ -130,7 +131,7 @@ module "region1_router1" { | |||
| bgp = { | |||
| asn = var.bgp_asn_subnet | |||
| advertised_groups = ["ALL_SUBNETS"] | |||
| advertised_ip_ranges = [{ range = local.restricted_googleapis_cidr }] | |||
| advertised_ip_ranges = var.private_service_cidr == null ? [{ range = local.google_private_service_range }] : [{ range = local.restricted_googleapis_cidr }] | |||
There was a problem hiding this comment.
this should be in a local since it is duplicated 4 times
renato-rudnicki
force-pushed
the
dns-refactory
branch
from
9df12d0 to
f7c4d14
Compare
No description provided.