This repository has been archived by the owner on Oct 9, 2019. It is now read-only.
Update to Storage Page #62
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he page were not updating on Keyup
|
Second request adds comments and tidy's up changes to .htaccess to make it work locally for me. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that the Storage page was not auto updating the local and session variables on the page on keyup as expected. I've updated the page to work with this now.
This is my first pull request ever Remy, so if I've made a balls of it, reject it and I'll try and redo it.
I added a function to force the content to update in those two onpage variables. This gets called when the "keyup" eventListener is triggered.