Use SPDX-License-Identifier: BSD-2-Clause instead of full text

[arichardson]

This makes the header at the top of each file a lot shorter.

[arichardson]

I did not touch the few cases of BSD-3-Clause, just the common header at the top of each non-contrib file.

[arichardson]

All done with simple search+replace (using 6 different patterns since the column width was different in various files)

[github-actions]

Test Results

   10 files  ±0     22 suites  ±0   0s ⏱️ ±0s
  697 tests ±0    697 ✅ ±0  0 💤 ±0  0 ❌ ±0 
2 173 runs  ±0  2 172 ✅ ±0  1 💤 ±0  0 ❌ ±0 

Results for commit 5eab966. ± Comparison against base commit 6a978ad.

♻️ This comment has been updated with latest results.

[Alasdair]

Looks nice, I do like pull requests that are: "+260 −5,686" 😃

I think the CI failure is probably some kind of storage failure on github's end, hopefully it'll go away by re-running.

[Alasdair]

Last failure is just the line number in some expected test output has changed due to the header size changing. There's a script test/typecheck/update_errors.sh or I could fix it after merging.

Failed: diff fail/prelude_no_order.error fail/prelude_no_order.expect
stdout:
5,6c5,6
<   | :51.0-22:
<   | 51 |$include <vector.sail>
---
>   | :72.0-22:
>   | 72 |$include <vector.sail>

[arichardson]

Last failure is just the line number in some expected test output has changed due to the header size changing. There's a script test/typecheck/update_errors.sh or I could fix it after merging.

Failed: diff fail/prelude_no_order.error fail/prelude_no_order.expect
stdout:
5,6c5,6
<   | :51.0-22:
<   | 51 |$include <vector.sail>
---
>   | :72.0-22:
>   | 72 |$include <vector.sail>

Ah I didn't think this would affect tests so I didn't bother runnign them. Let me fix that quickly.

[arichardson]

Last failure is just the line number in some expected test output has changed due to the header size changing. There's a script test/typecheck/update_errors.sh or I could fix it after merging.

Failed: diff fail/prelude_no_order.error fail/prelude_no_order.expect
stdout:
5,6c5,6
<   | :51.0-22:
<   | 51 |$include <vector.sail>
---
>   | :72.0-22:
>   | 72 |$include <vector.sail>

Ah I didn't think this would affect tests so I didn't bother runnign them. Let me fix that quickly.

Looks like that was the only issue and CI is happy now.

[arichardson]

ping?