Adding exit codes to all commands due to change in Symfony

Commands in symfony framework are now required to provide exit code in every `execute()` method.
remp2020 · Dec 27, 2019 · 6a5f3d4 · 6a5f3d4
1 parent 8031f88
commit 6a5f3d4
Show file tree

Hide file tree

Showing 9 changed files with 19 additions and 1 deletion.
diff --git a/src/commands/CalculateAveragesCommand.php b/src/commands/CalculateAveragesCommand.php
@@ -93,5 +93,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
  ON DUPLICATE KEY UPDATE `updated_at`=NOW(), `value`=VALUES(value);
 SQL
  );
+
+ return 0;
  }
 }
diff --git a/src/commands/CidGetterCommand.php b/src/commands/CidGetterCommand.php
@@ -46,6 +46,8 @@ protected function execute(InputInterface $input, OutputInterface $output)
  $this->cidMailDownloader->download(function ($mailContent) use ($output) {
  return $this->markMailProcessed($mailContent, $output);
  }, $input->getArgument('variable_symbol'));
+
+ return 0;
  }
 
  private function markMailProcessed($mailContent, $output)

diff --git a/src/commands/CsobMailConfirmationCommand.php b/src/commands/CsobMailConfirmationCommand.php
@@ -34,6 +34,8 @@ protected function execute(InputInterface $input, OutputInterface $output)
  $this->mailDownloader->download(function ($mailContents) use ($output) {
  return $this->markMailProcessed($mailContents, $output);
  });
+
+ return 0;
  }
 
  private function markMailProcessed(array $mailContents, OutputInterface $output)

diff --git a/src/commands/LastPaymentsCheckCommand.php b/src/commands/LastPaymentsCheckCommand.php
@@ -169,6 +169,8 @@ protected function execute(InputInterface $input, OutputInterface $output)
 
  $this->output->writeln("Done gateway <info>{$gateway->name}</info>\n");
  }
+
+ return 0;
  }
 
  /**

diff --git a/src/commands/RecurrentPaymentsCardCheckCommand.php b/src/commands/RecurrentPaymentsCardCheckCommand.php
@@ -57,5 +57,7 @@ public function execute(InputInterface $input, OutputInterface $output)
  $output->writeln('');
  $output->writeln('<info>All done. Took ' . round($duration, 2) . ' sec.</info>');
  $output->writeln('');
+
+ return 0;
  }
 }
diff --git a/src/commands/RecurrentPaymentsChargeCommand.php b/src/commands/RecurrentPaymentsChargeCommand.php
@@ -291,6 +291,8 @@ protected function execute(InputInterface $input, OutputInterface $output)
  $output->writeln('');
  $output->writeln('<info>All done. Took ' . round($duration, 2) . ' sec.</info>');
  $output->writeln('');
+
+ return 0;
  }
 
  private function validateRecurrentPayment($recurrentPayment)

diff --git a/src/commands/StopRecurrentPaymentsExpiresCommand.php b/src/commands/StopRecurrentPaymentsExpiresCommand.php
@@ -95,5 +95,7 @@ public function execute(InputInterface $input, OutputInterface $output)
  $output->writeln('');
  $output->writeln('<info>All done. Took ' . round($duration, 2) . ' sec.</info>');
  $output->writeln('');
+
+ return 0;
  }
 }
diff --git a/src/commands/TatraBankaMailConfirmationCommand.php b/src/commands/TatraBankaMailConfirmationCommand.php
@@ -34,6 +34,8 @@ protected function execute(InputInterface $input, OutputInterface $output)
  $this->mailDownloader->download(function ($mailContent) use ($output) {
  return $this->markMailProcessed($mailContent, $output);
  });
+
+ return 0;
  }
 
  private function markMailProcessed($mailContent, $output)

diff --git a/src/commands/UpdateRecurrentPaymentsExpiresCommand.php b/src/commands/UpdateRecurrentPaymentsExpiresCommand.php
@@ -73,7 +73,7 @@ public function execute(InputInterface $input, OutputInterface $output)
  $gateway = $this->paymentGatewaysRepository->findByCode($code);
  if (!$gateway) {
  $output->writeln("<error>ERROR: gateway <info>{$code}</info> doesn't exist:</error>");
- return;
+ return 1;
  }
  $recurrentPayments->where(['payment_gateway_id' => $gateway->id]);
  }
@@ -124,5 +124,7 @@ public function execute(InputInterface $input, OutputInterface $output)
  $output->writeln('');
  $output->writeln('<info>All done. Took ' . round($duration, 2) . ' sec.</info>');
  $output->writeln('');
+
+ return 0;
  }
 }