Adds fallback when processing DID_CHANGE_RENEWAL_STATUS notification …

…type In case of missing payment, new payment is created. remp/heldpesk#1130
remp2020 · Mar 4, 2022 · 68fe25c · 68fe25c
1 parent f6063dc
commit 68fe25c
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/src/Hermes/MissingPaymentException.php b/src/Hermes/MissingPaymentException.php
@@ -0,0 +1,7 @@
+<?php
+
+namespace Crm\AppleAppstoreModule\Hermes;
+
+class MissingPaymentException extends \Exception
+{
+}
diff --git a/src/Hermes/ServerToServerNotificationWebhookHandler.php b/src/Hermes/ServerToServerNotificationWebhookHandler.php
@@ -140,7 +140,13 @@ private function process($parsedNotification): bool
                         return $this->changeSubscriptionTypeOfNextPayment($latestReceiptInfo);
 
                     case ServerToServerNotification::NOTIFICATION_TYPE_DID_CHANGE_RENEWAL_STATUS:
-                        return $this->changeRenewalStatus($stsNotification, $latestReceiptInfo);
+                        try {
+                            return $this->changeRenewalStatus($stsNotification, $latestReceiptInfo);
+                        } catch (MissingPaymentException $exception) {
+                            Debugger::log($exception->getMessage(), Debugger::ERROR);
+                            // if payment is missing, fallback is to create payment again
+                            return $this->createPayment($latestReceiptInfo);
+                        }
 
                     case ServerToServerNotification::NOTIFICATION_TYPE_DID_FAIL_TO_RENEW:
                         $this->handleFailedRenewal($stsNotification, $latestReceiptInfo);
@@ -457,7 +463,7 @@ private function changeRenewalStatus(
             $originalTransactionID
         );
         if (empty($paymentMetas)) {
-            throw new \Exception("Unable to find (recurrent or non-recurrent) payment with `original_transaction_id` [{$originalTransactionID}]. Unable to change renewal status.");
+            throw new MissingPaymentException("Unable to find (recurrent or non-recurrent) payment with `original_transaction_id` [{$originalTransactionID}]. Unable to change renewal status.");
         }
 
         $lastPayment = reset($paymentMetas)->payment;