Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

templates: remove polyfill references #7271

Merged
merged 1 commit into from
Aug 31, 2023
Merged

templates: remove polyfill references #7271

merged 1 commit into from
Aug 31, 2023

Conversation

MichaelDeBoey
Copy link
Member

Follow-up of #7205 & @jacob-ebey's #7230

Templates are either calling installGlobals themselves or if they're using @remix-run/serve (fly, remix & remix-javascript), that already called installGlobals as well

remix/templates/arc/server.ts

Line 7 in c28c3cc

installGlobals();

remix/templates/express/server.js

Line 14 in c28c3cc

installGlobals();

remix/packages/remix-serve/cli.ts

Line 21 in c28c3cc

installGlobals();

@changeset-bot
Copy link

changeset-bot bot commented Aug 28, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: a20b828

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MichaelDeBoey MichaelDeBoey force-pushed the remove-polyfill-references-from-templates branch 3 times, most recently from 36147e8 to d7e380b Compare August 29, 2023 16:02
@MichaelDeBoey MichaelDeBoey mentioned this pull request Aug 29, 2023
Merged
@brophdawg11 brophdawg11 changed the base branch from dev to release-next August 30, 2023 17:52
@brophdawg11 brophdawg11 changed the base branch from release-next to dev August 30, 2023 17:52
@brophdawg11
Copy link
Contributor

@MichaelDeBoey do you mind rebasing this and repointing to release-next so these template changes will merge to main when we release 2.0.0?

@MichaelDeBoey MichaelDeBoey force-pushed the remove-polyfill-references-from-templates branch from 32f88f0 to 7073f50 Compare August 30, 2023 19:37
@MichaelDeBoey MichaelDeBoey changed the base branch from dev to release-next August 30, 2023 19:37
@MichaelDeBoey MichaelDeBoey force-pushed the remove-polyfill-references-from-templates branch from 7073f50 to a20b828 Compare August 31, 2023 14:29
@brophdawg11 brophdawg11 merged commit 1fdf868 into remix-run:release-next Aug 31, 2023
9 checks passed
@MichaelDeBoey MichaelDeBoey deleted the remove-polyfill-references-from-templates branch August 31, 2023 17:51
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 2.0.0-pre.5 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

🤖 Hello there,

We just published version v0.0.0-nightly-6c0310c-20230901 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

🤖 Hello there,

We just published version 2.0.0-pre.6 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2023

🤖 Hello there,

We just published version v0.0.0-nightly-9288516-20230902 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

🤖 Hello there,

We just published version 2.0.0-pre.7 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

🤖 Hello there,

We just published version 2.0.0-pre.7 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

🤖 Hello there,

We just published version v0.0.0-nightly-481f73e-20230906 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

🤖 Hello there,

We just published version 2.0.0-pre.8 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

🤖 Hello there,

We just published version v0.0.0-nightly-1a57073-20230907 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@lpsinger lpsinger mentioned this pull request Sep 7, 2023
Closed
1 task
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

🤖 Hello there,

We just published version 2.0.0-pre.9 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@brophdawg11 brophdawg11 mentioned this pull request Sep 7, 2023
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

🤖 Hello there,

We just published version v0.0.0-nightly-1fac238-20230908 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 2.0.0-pre.10 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-3646f91-20230914 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brophdawg11 brophdawg11 brophdawg11 approved these changes

@machour machour Awaiting requested review from machour

@markdalgleish markdalgleish Awaiting requested review from markdalgleish

@pcattori pcattori Awaiting requested review from pcattori

@jacob-ebey jacob-ebey Awaiting requested review from jacob-ebey

Assignees
No one assigned
Labels
CLA Signed docs package:dev template:architect template:express template:fly template:remix template:remix-javascript v2 Issues related to v2 apis
Projects
No open projects
v2
Status: Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaelDeBoey @brophdawg11