Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(discussion/04-server-vs-client.md): add headers #7260

Conversation

gustavoguichard
Copy link
Contributor

@gustavoguichard gustavoguichard commented Aug 25, 2023

On lines 11-15 of this page, headers is listed along with loader and action so I thought it'd be cool to update the example to add a headers export. If that is not desirable, the headers item should probably removed from that list.

Also couple lil copy fixes

@changeset-bot
Copy link

changeset-bot bot commented Aug 25, 2023

⚠️ No Changeset found

Latest commit: 8224f0d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MichaelDeBoey MichaelDeBoey changed the title docs(discussions): Adds headers to server-client discussion to illustrate according to topics docs(discussion/04-server-vs-client.md): add headers Aug 25, 2023
@MichaelDeBoey MichaelDeBoey added docs v2 Issues related to v2 apis labels Aug 25, 2023
@MichaelDeBoey
Copy link
Member

MichaelDeBoey commented Aug 25, 2023

Thanks for taking the time to create this PR @gustavoguichard! 🙏

However, I'm going to close this as the changes in here are already in #7191

@gustavoguichard
Copy link
Contributor Author

Cool @MichaelDeBoey ! Appreciate the progress on the docs ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed docs v2 Issues related to v2 apis
Projects
No open projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

2 participants