Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(remix-server-runtime): fix destroySession for cookies with maxAge #7252

Merged
merged 2 commits into from
Aug 25, 2023

Conversation

brophdawg11
Copy link
Contributor

Closes #5150

@brophdawg11 brophdawg11 self-assigned this Aug 24, 2023
@changeset-bot
Copy link

changeset-bot bot commented Aug 24, 2023

🦋 Changeset detected

Latest commit: b1ef72b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@remix-run/server-runtime Patch
@remix-run/cloudflare Patch
@remix-run/deno Patch
@remix-run/dev Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/architect Patch
@remix-run/express Patch
@remix-run/serve Patch
@remix-run/testing Patch
create-remix Patch
remix Patch
@remix-run/css-bundle Patch
@remix-run/eslint-config Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@MichaelDeBoey MichaelDeBoey changed the title Fix destroySession for maxAge cookies fix(remix-server-runtime): fix destroySession for cookies with maxAge Aug 25, 2023
@brophdawg11 brophdawg11 linked an issue Aug 25, 2023 that may be closed by this pull request
@brophdawg11 brophdawg11 merged commit 0a3ddcd into dev Aug 25, 2023
5 checks passed
@brophdawg11 brophdawg11 deleted the brophdawg11/delete-cookie-session branch August 25, 2023 19:18
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Aug 25, 2023
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-f77588e-20230826 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 2.0.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting release This issue has been fixed and will be released soon CLA Signed package:server-runtime
Projects
No open projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

destroySession doesn't delete cookie if max-age is set
2 participants