-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed up github actions for PRs #7250
Conversation
|
Update: It was because the |
@brophdawg11 You probably also need to update the required workflows for PRs, ... in the repo settings |
@@ -26,7 +26,7 @@ const config: PlaywrightTestConfig = { | |||
use: devices["Desktop Safari"], | |||
}, | |||
{ | |||
name: "edge", | |||
name: "msedge", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed the name of this profile to match the name of the browser (like the others) so we can use this name to only install the required browser during CI with:
npx playwright install --with-deps ${{ matrix.browser }}
That fails for edge
because playwright refers to it as msedge
Looks like something about the Update: Looks like since Edge is based on Chromium it just uses that as a default which explains the issue (from
I updated it to use actual MS Edge in 07f66e4 |
Co-authored-by: Michaël De Boey <[email protected]>
...devices["Desktop Edge"], | ||
// Desktop Edge uses chromium by default | ||
// https://github.com/microsoft/playwright/blob/main/packages/playwright-core/src/server/deviceDescriptorsSource.json#L1502 | ||
channel: "msedge", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops - we weren't actually using edge before 🙈
Co-authored-by: Michaël De Boey <[email protected]>
@brophdawg11 Required steps are now blocking PRs if docs-only PRs are made (see #7190) |
This PR splits up the GitHub actions a bit so we can be more granular (and therefore faster) on CI in PRs.
test-pr-ubuntu.yml
)create-remix
orremix-dev
are the most susceptible to Windows/OSX issues so when files in those packages are touched we also run the tests for Windows/OSX (test-pr-windows-macos.yml
)main
/dev
branches should still have the full suite run against them (test-full.yml
)