Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix MetaMatch type across client & server #7249

Merged
merged 2 commits into from
Aug 25, 2023
Merged

fix: fix MetaMatch type across client & server #7249

merged 2 commits into from
Aug 25, 2023

Conversation

brophdawg11
Copy link
Contributor

Closes #7239

@changeset-bot
Copy link

changeset-bot bot commented Aug 24, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 79a805c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@brophdawg11 brophdawg11 linked an issue Aug 24, 2023 that may be closed by this pull request
V2 issue: RemixServer context types are not happy with EntryContext from remix-run/node #7239
Closed
1 task
@brophdawg11 brophdawg11 added the v2 Issues related to v2 apis label Aug 24, 2023
@brophdawg11 brophdawg11 self-assigned this Aug 24, 2023
brophdawg11
brophdawg11 commented Aug 24, 2023
View reviewed changes
packages/remix-server-runtime/routeModules.ts
@@ -148,10 +151,14 @@ interface ServerRuntimeMetaMatch<
handle?: unknown;
params: AgnosticRouteMatch["params"];
meta: ServerRuntimeMetaDescriptor[];
error?: unknown;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This got added to the client types but not the server types

@brophdawg11 brophdawg11 force-pushed the brophdawg11/fix-metamatches-types branch from 779e123 to 1ef3e4e Compare August 24, 2023 16:05
brophdawg11
brophdawg11 commented Aug 24, 2023
View reviewed changes
packages/remix-react/routeModules.ts
Comment on lines +58 to +61
MatchLoaders extends Record<string, LoaderFunction | unknown> = Record<
string,
unknown
>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Align this with the type expected by MetaMatch

@brophdawg11 brophdawg11 force-pushed the brophdawg11/fix-metamatches-types branch from 1ef3e4e to c12443c Compare August 24, 2023 16:06
brophdawg11
brophdawg11 commented Aug 24, 2023
View reviewed changes
packages/remix-server-runtime/routeModules.ts
Comment on lines +134 to +137
ParentsLoaders extends Record<string, LoaderFunction | unknown> = Record<
string,
unknown
>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Align with the type expected by ServerRuntimeMetaMatch

@MichaelDeBoey MichaelDeBoey changed the title Fix typings for MetaMatch across server and client fix: fix MetaMatch type across client & server Aug 24, 2023
@MichaelDeBoey MichaelDeBoey force-pushed the brophdawg11/fix-metamatches-types branch from c12443c to f8f167a Compare August 24, 2023 18:39
@brophdawg11 brophdawg11 force-pushed the brophdawg11/fix-metamatches-types branch from f8f167a to 79a805c Compare August 25, 2023 18:26
@brophdawg11 brophdawg11 merged commit a9a36e2 into dev Aug 25, 2023
5 checks passed
@brophdawg11 brophdawg11 deleted the brophdawg11/fix-metamatches-types branch August 25, 2023 19:19
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Aug 25, 2023
@brophdawg11 brophdawg11 mentioned this pull request Aug 25, 2023
Closed
1 task
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-f77588e-20230826 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 2.0.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@KarelVerschraegen KarelVerschraegen mentioned this pull request Sep 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelDeBoey MichaelDeBoey MichaelDeBoey approved these changes

Assignees

@brophdawg11 brophdawg11

Labels
awaiting release This issue has been fixed and will be released soon CLA Signed feat:typescript package:server-runtime renderer:react v2 Issues related to v2 apis
Projects
No open projects
v2
Status: Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

V2 issue: RemixServer context types are not happy with EntryContext from remix-run/node
2 participants
@brophdawg11 @MichaelDeBoey