feat(remix-node): use Web Crypto API in createFileSessionStorage (#…

…7203) Co-authored-by: Matt Brophy <[email protected]>
remix-run · Aug 30, 2023 · 10d95f0 · 10d95f0
1 parent 00d1f39
commit 10d95f0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/.changeset/node-web-crypto.md b/.changeset/node-web-crypto.md
@@ -0,0 +1,5 @@
+---
+"@remix-run/node": patch
+---
+
+Switch from `crypto.randomBytes` to `crypto.webcrypto.getRandomValues` for file session storage ID generation
diff --git a/packages/remix-node/sessions/fileStorage.ts b/packages/remix-node/sessions/fileStorage.ts
@@ -42,7 +42,7 @@ export function createFileSessionStorage<Data = SessionData, FlashData = Data>({
       while (true) {
         // TODO: Once Node v19 is supported we should use the globally provided
         // Web Crypto API's crypto.getRandomValues() function here instead.
-        let randomBytes = crypto.randomBytes(8);
+        let randomBytes = crypto.webcrypto.getRandomValues(new Uint8Array(8));
         // This storage manages an id space of 2^64 ids, which is far greater
         // than the maximum number of files allowed on an NTFS or ext4 volume
         // (2^32). However, the larger id space should help to avoid collisions