Skip to content

Commit

Permalink
write build version to version.txt alongside the server build (#7299)
Browse files Browse the repository at this point in the history
  • Loading branch information
pcattori authored Aug 30, 2023
1 parent 7ed1546 commit 0a33b2c
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 1 deletion.
5 changes: 5 additions & 0 deletions .changeset/pretty-ears-vanish.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@remix-run/dev": patch
---

internal: write a version.txt sentinel file _after_ server build is completely written
12 changes: 11 additions & 1 deletion packages/remix-dev/compiler/compiler.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import * as fs from "node:fs";
import * as path from "node:path";

import type { Context } from "./context";
Expand Down Expand Up @@ -119,7 +120,16 @@ export let create = async (ctx: Context): Promise<Compiler> => {
let server = await tasks.server;
if (!server.ok) throw error ?? server.error;
// artifacts/server
writes.server = Server.write(ctx.config, server.value);
writes.server = Server.write(ctx.config, server.value).then(() => {
// write the version to a sentinel file _after_ the server has been written
// this allows the app server to watch for changes to `version.txt`
// avoiding race conditions when the app server would attempt to reload a partially written server build
let versionTxt = path.join(
path.dirname(ctx.config.serverBuildPath),
"version.txt"
);
fs.writeFileSync(versionTxt, manifest.version);
});

await Promise.all(Object.values(writes));
return manifest;
Expand Down

0 comments on commit 0a33b2c

Please sign in to comment.