Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix tests by updating snapshots #17

Closed
wants to merge 2 commits into from

Conversation

bdenham
Copy link

@bdenham bdenham commented Dec 18, 2022

This PR fixes all the tests by updating the failing snapshots.

@remcohaszing
Copy link
Owner

remcohaszing commented Dec 19, 2022

Tests are still failing, because mermaid output is unstable. They are relatively stable on my machine, but that doesn’t help in CI.

I would love to have a solution for this, but unfortunately just updating snapshots isn’t it. See #5

The Node 14 tests seem to fail for other reasons related to the dev setup, so I’ll just remove those.

@bdenham
Copy link
Author

bdenham commented Dec 20, 2022

Ah, ok. Same here with being relatively stable locally. Bummer. But good to know. Thanks!

@remcohaszing remcohaszing mentioned this pull request Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants