Skip to content

Commit

Permalink
Remove hardcoded download url
Browse files Browse the repository at this point in the history
  • Loading branch information
spaceo committed May 17, 2024
1 parent 58950fb commit 64acd9e
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions .github/workflows/create-release-on-branch-changes.yml
Original file line number Diff line number Diff line change
Expand Up @@ -83,13 +83,14 @@ jobs:
files: ${{ env.DIST_FILENAME }}

- name: Write release information in artifact file
# TODO: Remember to change hardcoded download url.
run: |
printf '{
"release_branch": "${{ env.RELEASE_BRANCH }}",
"dependency_package": "danskernesdigitalebibliotek/dpl-react",
"release_download_url": "https://github.com/reload/poc-dpl-react-pr-trigger/releases/download/${{ env.TAG_NAME }}/${{ env.DIST_FILENAME }}"
"release_download_url": "${{ env.DOWNLOAD_URL }}"
}' >> release-info.json
env:
DOWNLOAD_URL: "${{ github.event.repository.html_url }}/releases/download/${{ env.TAG_NAME }}/${{ env.DIST_FILENAME }}"

- uses: actions/upload-artifact@v3
with:
Expand Down

0 comments on commit 64acd9e

Please sign in to comment.