Multiarch images #323
Merged
Multiarch images #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnested
force-pushed
the
poc
branch
2 times, most recently
from
01ca3e6 to
9fb7a7f
Compare
Update PHP images to use multiarch SHA's
|
We can probably lower the ARM build time by creating an ARM-based runner: https://github.blog/news-insights/product-news/arm64-on-github-actions-powering-faster-more-efficient-build-systems/ |
xendk
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds in GitHub Actions warned that the SHA's in the Dockerfile referenced AMD version when building the ARM versions.
This pull request changes the PHP images to references a multiarch SHA and thus avoids that complaint.
The increases the build time of the ARM images dramatically! They used to build in 3–4 minutes, but now it takes 35–45 minutes! I have no clue why. The AMD images still build in 3–4 minutes.
To mitigate the long build time, I introduced caching of docker layers (based on https://docs.docker.com/build/ci/github-actions/cache/). A cached rebuild is now down 3–4 seconds.
I also reordered some instructions in the Dockerfile so that we'll be able to reuse the cached layers more often (when updating the Blackfire CLI and the composer CLI) and only suffer the long build time when we update the base PHP images.
The Dockerfile still references AMD image SHA's for the Blackfire CLI, the composer CLI, and the mlocati/php-extension-installer CLI.
Those are updated by @dependabot, and I haven't figured out if we can make Dependabot use the multiarch SHA's.