Allow sudo for all instead of just members of the wheel group #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already claim this in the README: > This being an image for development use, we have installed sudo and configured all users in the container to use it without providing a password. Previously we did this by making sure the typical users were in the wheel group. But with a recent update (probably to the underlying alpine image -- but I'm not sure) the process doesn't have knowledge of this unless we run Docker with the `--group-add wheel` option. We want to avoid that. So let's just implement what we actually claim in the documentation. This should also be better for the non-standard use case where someone runs the container using a "non-stanard" user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already claim this in the README:
Previously we did this by making sure the typical users were in the
wheel group.
But with a recent update (probably to the underlying alpine image --
but I'm not sure) the process doesn't have knowledge of this unless we
run Docker with the
--group-add wheeloption.We want to avoid that. So let's just implement what we actually claim
in the documentation. This should also be better for the non-standard
use case where someone runs the container using a "non-stanard" user.