Skip to content

Commit

Permalink
Storybook tweaks
Browse files Browse the repository at this point in the history
  • Loading branch information
blyme committed Oct 4, 2024
1 parent b506833 commit 591ed22
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
1 change: 1 addition & 0 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -51,3 +51,4 @@ FROM proxy AS storybook
COPY /storybook /

ENV NGINX_PROXY_PASS http://app:6006

Check warning on line 53 in Dockerfile

View workflow job for this annotation

GitHub Actions / HTTPS Proxy (storybook, linux/arm64)

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

Check warning on line 53 in Dockerfile

View workflow job for this annotation

GitHub Actions / HTTPS Proxy (storybook, linux/amd64)

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/
ENV SERVER_CHANNEL_PROXY_PASS ws://app:6006/storybook-server-channel

Check warning on line 54 in Dockerfile

View workflow job for this annotation

GitHub Actions / HTTPS Proxy (storybook, linux/arm64)

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

Check warning on line 54 in Dockerfile

View workflow job for this annotation

GitHub Actions / HTTPS Proxy (storybook, linux/amd64)

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/
5 changes: 5 additions & 0 deletions context/storybook/etc/nginx/templates/default.conf.template
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ server {

location / {
proxy_pass ${NGINX_PROXY_PASS};
proxy_pass_reverse ${NGINX_PROXY_PASS};
}

location /__webpack-hmr {
Expand All @@ -15,4 +16,8 @@ server {
proxy_set_header Connection "Upgrade";
proxy_set_header Host $host;
}

location /storybook-server-channel {
proxy_pass ${SERVER_CHANNEL_PROXY_PASS};
}
}

0 comments on commit 591ed22

Please sign in to comment.