Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CI #48

Merged
merged 2 commits into from
Sep 11, 2023
Merged

Improve CI #48

merged 2 commits into from
Sep 11, 2023

Conversation

jm-wk
Copy link
Contributor

@jm-wk jm-wk commented Sep 5, 2023

We add a pre-commit.ci configuration that will automatically add a commit with code formatting from black and isort.

We update the version of pylint to the latest stable 2.17 version.

We also add a mypy type checker configured so that the checker only issues warnings and does not fail the whole CI. We configure mypy to be as lenient as possible.

@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (cba2f72) 100.00% compared to head (ce2d01c) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #48   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines          782       782           
=========================================
  Hits           782       782           
Files Changed Coverage Δ
...i_manifest/worker/tasks/depsolver/rpm_depsolver.py 100.00% <ø> (ø)
ubi_manifest/worker/tasks/depsolve.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

@jm-wk jm-wk marked this pull request as ready for review September 5, 2023 13:20
@rbikar
Copy link
Member

rbikar commented Sep 5, 2023

pre-commit.ci run

rbikar
rbikar previously approved these changes Sep 7, 2023
We add a pre-commit.ci configuration that will automatically add a
commit with code formatting from black and isort.

We update the version of pylint to the latest stable 2.17 version.

We also add a mypy type checker configured so that the checker only
issues warnings and does not fail the whole CI. We configure mypy to be
as lenient as possible.

We also modify the triggers for tox tests, so that the whole suite is
being run only once per PR.
@rbikar rbikar merged commit a48927f into release-engineering:master Sep 11, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants