Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for multiple content config sources [RHELDST-19139] #44

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

rbikar
Copy link
Member

@rbikar rbikar commented Jul 19, 2023

Introduced new configuration option (json string) called
content_config with format {repo_group_prefix: url}.

Anytime clients request generation of the ubi-manifest for some
repositories, url of content configuration repository is
determined by matching the repo group prefix with content_config
configuration item.

Old config ubi_config_url was removed and only the new one
will be used.

@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (62f3e4d) 100.00% compared to head (e56761d) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #44   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines          718       723    +5     
=========================================
+ Hits           718       723    +5     
Impacted Files Coverage Δ
ubi_manifest/app/api.py 100.00% <100.00%> (ø)
ubi_manifest/worker/tasks/config.py 100.00% <100.00%> (ø)
ubi_manifest/worker/tasks/depsolve.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Introduced new configuration options (json string) called
`content_config` with format `{repo_group_prefix: url}`.

Anytime clients request generation of the ubi-manifest for some
repositories, url of content configuration repository is
determined by matching the repo group prefix with `content_config`
configuration item.

Old config `ubi_config_url` was removed and only the new one
will be used.
@rbikar rbikar changed the title TODO Support for multiple content config sources [RHELDST-19139] Jul 19, 2023
@rbikar rbikar marked this pull request as ready for review July 19, 2023 10:46
@rbikar rbikar requested a review from MichalHaluza July 19, 2023 10:47
@rbikar rbikar merged commit d58efe2 into release-engineering:master Jul 20, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants