Comply to newer versions of pylint [RHELDST-26606] (#215)

+ Change .pylintrc to ignore `too-many-positional-arguments`
+ Assign variables by default when they are possibly unbound

.pylintrc

@@ -8,4 +8,5 @@ disable=fixme,
  too-many-instance-attributes,
  too-many-statements,
  too-many-arguments,
+ too-many-positional-arguments,
 

tests/test_depsolve_task.py

@@ -3,8 +3,15 @@
 from unittest import mock
 
 import pytest
-from pubtools.pulplib import Distributor, ModulemdDefaultsUnit, ModulemdUnit, RpmUnit
+from pubtools.pulplib import (
+ Distributor,
+ ModulemdDefaultsUnit,
+ ModulemdUnit,
+ RpmUnit,
+ Unit,
+)
 
+from ubi_manifest.worker.models import UbiUnit
 from ubi_manifest.worker.tasks import depsolve
 from ubi_manifest.worker.ubi_config import ContentConfigMissing
 
@@ -871,6 +878,30 @@ def test_multiple_population_sources(pulp):
  assert unit["value"] == "gcc_src_debug-1-0.src.rpm"
 
 
+@mock.patch("ubi_manifest.worker.tasks.depsolve.redis.from_url")
+def test_save_with_invalid_inner_unit(mock_redis_from_url):
+ """Test scenario to reach the else continue statement in the _save() function
+ of depsolve_task."""
+
+ class InvalidInnerUnit(Unit):
+ def __init__(self):
+ super().__init__(content_type_id="mock_content")
+
+ redis = MockedRedis(data={})
+ mock_redis_from_url.return_value = redis
+
+ invalid_unit = UbiUnit(
+ unit=InvalidInnerUnit(),
+ src_repo_id="mock_repo_id",
+ )
+
+ data = {"mock_repo_id": [invalid_unit]}
+
+ depsolve._save(data)
+
+ mock_redis_from_url.set.assert_not_called()
+
+
 def test_missing_content_config(pulp):
  """Exception is raised where there is no matching ubi content config"""
  _setup_repos_missing_config(pulp)

ubi_manifest/worker/tasks/config.py

@@ -22,7 +22,10 @@ def validate_content_config(_: AttrsInstance, attr: Any, value: dict[str, str])
  for repo_class, url_or_dir in value.items():
  if not re.match(REPO_CLASS_REGEX, repo_class):
  raise ValueError(
- f"Repo classes in '{attr.name}' must match regex '{REPO_CLASS_REGEX}'. '{repo_class}' doesn't."
+ (
+ f"Repo classes in '{attr.name}' must match regex '{REPO_CLASS_REGEX}'."
+ f"'{repo_class}' doesn't."
+ )
  )
  url_or_dir = str(url_or_dir)
  if url_or_dir.lower().startswith(("http://", "https://")):
@@ -33,7 +36,8 @@ def validate_content_config(_: AttrsInstance, attr: Any, value: dict[str, str])
  value_type = "Path"
  if not re.match(regex, url_or_dir, re.VERBOSE):
  raise ValueError(
- f"{value_type} to config in '{attr.name}' must match regex '{regex}'. '{url_or_dir}' doesn't."
+ f"{value_type} to config in '{attr.name}' must match regex '{regex}'."
+ f"'{url_or_dir}' doesn't."
  )
 
 

ubi_manifest/worker/tasks/content_audit.py

@@ -73,6 +73,7 @@ def content_audit_task() -> None:
  in_repos = client.search_repository(
  Criteria.with_id(out_repo.population_sources)
  )
+ modular_rpm_filenames = set()
  if has_modules:
  modular_rpm_filenames = get_pkgs_from_all_modules(
  list(in_repos) + [out_repo]

ubi_manifest/worker/tasks/depsolve.py

@@ -208,6 +208,7 @@ def _save(data: dict[str, list[UbiUnit]]) -> None:
  for repo_id, units in data.items():
  items = []
  for unit in units:
+ item = {}
  if unit.isinstance_inner_unit(RpmUnit):
  item = {
  "src_repo_id": unit.associate_source_repo_id,
@@ -229,6 +230,8 @@ def _save(data: dict[str, list[UbiUnit]]) -> None:
  "unit_attr": "name:stream",
  "value": f"{unit.name}:{unit.stream}",
  }
+ else:
+ continue
  items.append(item)
 
  data_for_redis[repo_id] = items