Add uefi boot support to compose data [RHELDST-18235] #356
Conversation
amcmahon-rh
requested review from
rohanpm,
rbikar and
chandwanitulsi
as code owners
amcmahon-rh
force-pushed
the
AddBootMode
branch
from
273fc0f
to
c533197
Compare
From RHEL 8.9 and RHEL 9.3 onwards UEFI will be available. The boot mode must be specified for AMI images to make use of the change. This change adds the boot mode to the metadata parsed in from composes. Data will be used by pubtools-ami and passed to cloudimg
amcmahon-rh
force-pushed
the
AddBootMode
branch
from
6fe7417
to
b730224
Compare
for more information, see https://pre-commit.ci
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #356 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 53 53
Lines 2241 2242 +1
=========================================
+ Hits 2241 2242 +1
☔ View full report in Codecov by Sentry. |
| type=bool, default=None, validator=optional(instance_of(bool)) | ||
| ) | ||
| """``True`` if the image supports UEFI boot.""" | ||
|
|
There was a problem hiding this comment.
@amcmahon-rh It is not such simple boolean value.
Image builder provides additional metadata in koji build e.g.
'extra': {'typeinfo': {'image': {'rhel-azure-9.3-20230823.14.aarch64.vhd.xz': {'arch': 'aarch64',
'boot_mode': 'uefi'},
'rhel-azure-9.3-20230823.14.x86_64.vhd.xz': {'arch': 'x86_64',
'boot_mode': 'hybrid'}}}},
aarch64 obviously has to use uefi. But with x86_64 it should try uefi but it can do fallback
in AWS terminology, it is 3 state: "uefi-preferred", "legacy-bios" and "uefi"
- https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/ami-boot-mode.html
And one cannot achieve that with boolean in cloudimg - https://github.com/amcmahon-rh/cloudimg/blob/1ae154580abbeb5ed555d443a2c9bcd61ed1ef70/cloudimg/aws.py#L53
There was a problem hiding this comment.
Hey @lslebodn, I don't quite understand, could you elaborate please?
I understand that AWS requires specific string values. The idea of using a boolean was to keep the value abstract up to the point where we actually interact with AWS, rather than passing string values around different libraries.
Would this be resolved by having a second boolean? One for uefi and one for bios support?
There was a problem hiding this comment.
@amcmahon-rh there are 4 possible ways for adding "BootMode" for image.
a) missing option "BootMode"
b) one of following values: uefi, legacy-bios, or uefi-preferred as it is described in AWS documentation(https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/ami-boot-mode.html)
And we cannot achieve it with current with current "type=bool".
Because based on value of boolean cloudimg can use either "uefi-preferred" or "legacy-bios"
For aarch64 images, "uefi-preferred" is not ideal. It should be either "uefi" or the "BootMode" should not be specified at all when uploading image as it was before this change
From RHEL 8.9 and RHEL 9.3 onwards UEFI will be available. The boot mode must be specified for AMI images to make use of the change. This change adds the boot mode to the metadata parsed in from composes. Data will be used by pubtools-ami and passed to cloudimg