Community: Prevent null billing config on upload #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
JAVGan
force-pushed
the
bconf
branch
2 times, most recently
from
b1808e5
to
412c765
Compare
This commit changes the `community_push.items._set_push_item_billing_code` function to prevent returning a push item with no billing codes. The function `_set_push_item_billing_code` is only called when the billing config is required and it doesn't make sense to let a push item miss it when this value is required. It also improve the billing config matching debugging logs to help analyze what could have happened when such push item doesn't have a billing code match. Refers to SPSTRAT-408
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the
community_push.items._set_push_item_billing_codefunction to prevent returning a push item with no billing codes.The function
_set_push_item_billing_codeis only called when the billing config is required and it doesn't make sense to let a push item miss it when this value is required.It also improve the billing config matching debugging logs to help analyze what could have happened when such push item doesn't have a billing code match.
Refers to SPSTRAT-408