Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make LoggingThread recover on all errors [RHELDST-332] #248

Commits on Feb 6, 2024

  1. Make LoggingThread recover on all errors [RHELDST-332]

    Previously, LoggingThread would recover from any XML-RPC fault, but
    would stop when any other type of exception was encountered.
    That is a problem, as it means the worker will permanently give
    up sending messages to the hub when all kinds of temporary
    issues occur (e.g. a temporary network disruption between worker
    and hub). The task underneath may continue running for hours,
    with all log messages being discarded.
    
    Given the nature of this thread, it makes more sense to attempt
    recovering from all kinds of errors, as we should try hard not
    to lose log messages from a task.
    
    Fixes release-engineering#60
    
    (This commit is a reimplementation of
    release-engineering#106)
    crungehottman committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    b504131 View commit details
    Browse the repository at this point in the history