fix command line argument order #105
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the patch! You mean the POSIXLY_CORRECT case, right? A user can call mount.exfat-fuse directly and is in full right to put device and mountpoint after other options. Your change breaks this use-case. It also breaks I'd suggest to mutate argv[] instead (i.e. to do what glibc does) to cover all those cases. |
The mount spec and directory are passed as the first and second arguments to the helper, followed by the options. The current implementation works on glibc but fails on POSIX-conforming C libraries such as musl.
|
Arbitrary argument order supported now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mount spec and directory are passed as the first and second
arguments to the helper, followed by the options.
The current implementation works on glibc but fails on POSIX-conforming
C libraries such as musl.