Fuzz test convert and twins scenario #98
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit replaces the tostring.go file with the proto2.GoString() function that takes a generic proto.Message and returns a Go struct literal. This commit also replaces the interfaces AlmostFuzzMsg and FuzzMsgInterface with two simple helpers extractProtoMsg() and fuzzMsgToHotStuffMsg(). These are easier to use and IMO easier to maintain. Additionally, there are a few smaller tweaks.
Also, there is no need to export these types at this point, since they are not being used from outside the fuzz package.
|
Not ready to merge this yet or if it will be mergeable in the future..., but I've cleaned up some of the code, in particular related to printing protobuf messages as Go struct literals and replaced some of the confusing interface logic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new testing tool using google/gofuzz to create a random hotstuff.pb.go message, and uses functions in convert.go to create a message that will be used in a twins scenario test by replacing it with the first message sent from a node in the scenario test. Crashes accumulates over a series of tests with different random messages and gets output in an organized list after the test is run 1000 times.
made by Asbjørn Salhus and Magnus Brandsegg
cd fuzz
go test -run TestFuzz