Fix TimeoutMsgFromProto reported in issue 129 #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When initializing the TimeoutMsg.MsgSignature field it required that the TimeoutMsg's ViewSignature was non-nil instead of checking for the MsgSignature being non-nil. It is not clear to me if this can happen in practice, but this fixes the problem. Thanks to @ikmOfSA for reporting the bug.
This formats the scripts and removes the version line from the docker-compose.yml file. The deploy_test.sh script also replaces docker-compose with "docker compose" since GitHub now only supports version 2 and higher of docker compose.
Running the deploy_test.sh script gave the following error:
failed to connect to remote hosts: dial tcp: lookup hotstuff_worker_4 on 127.0.0.11:53: no such host
Based on suggestion by ChatGPT, we should replace the underscore
with a dash to avoid having to specify container names explicitly
in the docker-compose.yml file, which seemed more awkward:
container_name: "hotstuff_worker_{{.Task.Slot}}"
See previous commit for reasoning; makes it easier with docker compose.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #130 +/- ##
==========================================
- Coverage 62.55% 61.88% -0.68%
==========================================
Files 79 79
Lines 7584 7584
==========================================
- Hits 4744 4693 -51
- Misses 2539 2579 +40
- Partials 301 312 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When initializing the TimeoutMsg.MsgSignature field it required
that the TimeoutMsg's ViewSignature was non-nil instead of checking
for the MsgSignature being non-nil.
It is not clear to me if this can happen in practice, but this
fixes the problem.
Thanks to @ikmOfSA for reporting the bug.
Fixes #129