Merge pull request #123 from relab/fixeddsa

Fix eddsa private key parsing bug
relab · Mar 12, 2024 · daffe57 · daffe57
2 parents 301532c + 18716fd
commit daffe57
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/crypto/keygen/keygen.go b/crypto/keygen/keygen.go
@@ -233,7 +233,15 @@ func ParsePrivateKey(buf []byte) (key hotstuff.PrivateKey, err error) {
 	case ecdsacrypto.PrivateKeyFileType:
 		key, err = x509.ParseECPrivateKey(b.Bytes)
 	case eddsa.PrivateKeyFileType:
-		key = ed25519.NewKeyFromSeed(b.Bytes[:32])
+		genericKey, err := x509.ParsePKCS8PrivateKey(b.Bytes)
+		if err != nil {
+			return nil, err
+		}
+		var ok bool
+		key, ok = genericKey.(ed25519.PrivateKey)
+		if !ok {
+			return nil, fmt.Errorf("failed to parse key")
+		}
 	case bls12.PrivateKeyFileType:
 		k := &bls12.PrivateKey{}
 		k.FromBytes(b.Bytes)