Skip to content

Commit

Permalink
Merge pull request #16 from rekuberate-io/14-do-not-update-runner-cro…
Browse files Browse the repository at this point in the history
…njobs-if-they-are-actively-running

check cronjob status active refs
  • Loading branch information
akyriako authored May 30, 2024
2 parents 9bfd154 + ffb9b1c commit f8aa549
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 7 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@

# Image URL to use all building/pushing image targets
#IMG_TAG ?= $(shell git rev-parse --short HEAD)
IMG_TAG ?= 0.2.0
IMG_TAG ?= 0.2.1
IMG_NAME ?= rekuberate-io-sleepcycles
DOCKER_HUB_NAME ?= $(shell docker info | sed '/Username:/!d;s/.* //')
IMG ?= $(DOCKER_HUB_NAME)/$(IMG_NAME):$(IMG_TAG)
Expand Down
4 changes: 2 additions & 2 deletions charts/sleepcycles/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.2.0
version: 0.2.1
# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
# follow Semantic Versioning. They should reflect the version the application is using.
# It is recommended to use it with quotes.
appVersion: "0.2.0"
appVersion: "0.2.1"
2 changes: 1 addition & 1 deletion charts/sleepcycles/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ controllerManager:
- ALL
image:
repository: akyriako78/rekuberate-io-sleepcycles
tag: 0.2.0
tag: 0.2.1
resources:
limits:
cpu: 500m
Expand Down
2 changes: 1 addition & 1 deletion config/manager/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,4 @@ kind: Kustomization
images:
- name: controller
newName: akyriako78/rekuberate-io-sleepcycles
newTag: 0.2.0
newTag: 0.2.1
6 changes: 4 additions & 2 deletions controllers/sleepcycle_runners_cronjobs.go
Original file line number Diff line number Diff line change
Expand Up @@ -223,9 +223,11 @@ func (r *SleepCycleReconciler) reconcileCronJob(
}
}

//TODO: If cronjob is actively running, quit and wait next reconciliation loop

if cronjob != nil {
if cronjob.Status.Active != nil {
return nil
}

if !isShutdownOp && sleepcycle.Spec.WakeUp == nil {
err := r.deleteCronJob(ctx, sleepcycle, cronjob)
if err != nil {
Expand Down

0 comments on commit f8aa549

Please sign in to comment.