Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renewal dashboard frontend #83

Merged
merged 94 commits into from
Apr 25, 2019
Merged

Conversation

keigohtr
Copy link
Member

What is this PR for?

Frontend renewal for the backend renewal. -> #75

This PR includes

  • Add UI for data_server
  • Add UI for Project
  • Add UI for Project Access Right
  • Replace redux-form to formik
  • Use Yup

What type of PR is it?

Feature

What is the issue?

#66
#61

How should this be tested?

No frontend test available...

Copy link
Member

@yoquankara yoquankara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's so much changes - kudos to the achievement : )

I'm not a front end expert, but it does LGTM in general. One thing to improve is to add UI test in future.

Copy link
Member

@yuki-mt yuki-mt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not about this PR, but I found something wrong in frontend:

  • The current dispatchers do no use thunk, so we can remove react-thunk, I guess.
  • typo: APIRequestStatusList.failue -> failure
  • no 404 page or redirect for 404
    • Now you can access to /projects/{non_existing_project_id}/data_servers , and submit. This can be confusing although this is a minor issue.

frontend/src/apis/index.tsx Show resolved Hide resolved
frontend/src/apis/index.tsx Show resolved Hide resolved
frontend/src/components/Common/Field/Checkbox.tsx Outdated Show resolved Hide resolved
@keigohtr
Copy link
Member Author

@yuki-mt Thank you for your review.

The current dispatchers do no use thunk, so we can remove react-thunk, I guess.

I am not familiar with redux, so could you send us the PR for this?

@yuki-mt
Copy link
Member

yuki-mt commented Apr 25, 2019

@keigohtr
OK! I will send a new PR to remove redux-thunk .

@keigohtr
Copy link
Member Author

@yuki-mt

typo: APIRequestStatusList.failue -> failure
Now you can access to /projects/{non_existing_project_id}/data_servers , and submit. This can be confusing although this is a minor issue.

I have updated!

@keigohtr
Copy link
Member Author

@yuki-mt
I have updated!

OK! I will send a new PR to remove redux-thunk .

After this PR is merged, all issues will be solved! Thank you!

Copy link
Member

@yuki-mt yuki-mt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! Great work, a lot of progress has been made :)

(I believe all tests will be passed)

@keigohtr keigohtr merged commit 1a1f862 into master Apr 25, 2019
@keigohtr keigohtr deleted the feature/renewal-dashboard-frontend branch April 25, 2019 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants