Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SteamIdHashSalt no longer treats empty value as 'no salt', breaking default configuration. #1

Open
rtxa opened this issue Jul 21, 2024 · 3 comments

Comments

@rtxa
Copy link

rtxa commented Jul 21, 2024

In the latest version, Reunion no longer treats an empty SteamIdHashSalt value as "no salt". Instead, it is now flagging the empty value as being too short, requiring you to provide a non-empty salt string, otherwise it will not run.

@rtxa
Copy link
Author

rtxa commented Aug 8, 2024

Hi @s1lentq, do you mind taking a look to this issue? In the current state, the latest release version is broken out-of-the-box, which would be undesired for users who want to try the latest Reunion and find out isn't working.

@s1lentq
Copy link
Collaborator

s1lentq commented Aug 8, 2024

Since the recommended AuthVersion is set to 3 by default,
a salt is required for this version for security reasons.
As noted in the configuration: # AuthVersion >= 3: If string is empty, init will fail.

I believe it is better to set the salt explicitly once, ensuring the user is aware of and controls this security feature.

@rtxa
Copy link
Author

rtxa commented Aug 8, 2024

Hmm, I don't think this is the best approach, servers owners not aware of this change would not understand why Reunion isn't working in the new version without reading the configuration documentation, error message is not clear about this change, installation instructions neither (also this add a new configuration step). Perhaps a better solution would be to warn in console about SteamIdHashSalt being required when using the new auth version and falling back to AuthVersion2, but I think's is a too agressive aproach not letting Reunion start.

By the way, what's the difference between AuthVersion 2 and 3?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants