Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix imagefap gallery title. #31

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix imagefap gallery title. #31

wants to merge 2 commits into from

Conversation

Notay
Copy link
Contributor

@Notay Notay commented Aug 24, 2017

Removes "Porn pics of" and "(Page 1)" from imagefap gallery titles.

@@ -11,7 +11,7 @@
# identifier (default = name of this plugin after "plugin_") : If there's a match, we'll attempt to download images using this plugin.

# title: parses the gallery page for a title. This will be the folder name of the output gallery.
title = r'<title>(.+?)</title>'
title = r'<title>Porn pics of (.+?) \(Page 1\)</title>'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if:
a) the user passes a link to a page that isn't Page 1? You could replace the 1 with \d+ which should work for all expected numbers.
b) what if the site changes the format of their titles? Can you change the regex to make the prefix and suffix optional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a) From my experience it is always (Page 1), whether you are on page 1 or page 8.
b) That's a good idea, at the moment I don't trust my regex skills for such a task. http://www.imagefap.com/forum/viewtopic.php?f=18&t=14892 makes it seem like they haven't updated there layout in awhile and don't plane to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants