Fix selected header columns with no name #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whilst investigating whether the column index was carried through in the sample (it isn't) ended up refactoring the function a little.
alaric-rd
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Maybe we would want to use spreadsheet-style absolute column references rather than a counter that goes up only on each unnamed column ("Column C" makes sense for .xls/.ods files; there's no particular convention for .csv so I suppose doing the same is best)? But quibbling over maybes like that in code reviews is foolish, this works so let's go with it and change it later if people complain!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when the call to GetHeaders encounters a cell with no value (e.g. a header with no text) then it fails to correctly extract header text.
This fixes the issue (and resolves #93) but the result is that we have excluded any selected header that has no text. We give this a default name
[Untitled column n]where n is an incrementing number. This currently looks like