Accessibility improvements to sheet selector component #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
– Use a <caption> element which more accurately describes the table content for screen readers - Use CSS visibility instead of display to control which sheet is shown which means invisible sheets continue to occupy screen space, so the below elements don't move around on the screen when the selection is changed, which is difficult for people with certain cognitive issues - Move CSS/JS into separate files for easier reuse in the docs
rossjones
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<caption>element which more accurately describes the table content for screen readersvisibilityinstead ofdisplayto control which sheet is shown which means invisible sheets continue to occupy screen space, so the below elements don't move around on the screen when the selection is changed, which is difficult for people with certain cognitive issuesaria-hiddenattributes to hide invisible sheets from screen readersWDYT @rossjones ?