Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use backend.SessionSuggestDataRange rather than computing our own ranges #51

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Use backend.SessionSuggestDataRange rather than computing our own ranges #51

merged 1 commit into from
Sep 10, 2024

Conversation

alaric-rd
Copy link
Contributor

Fixes #50

@alaric-rd alaric-rd mentioned this pull request Sep 10, 2024
Closed
rossjones
rossjones approved these changes Sep 10, 2024
View reviewed changes
Copy link
Collaborator

@rossjones rossjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

simonwo
simonwo approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@simonwo simonwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep works!

@alaric-rd alaric-rd merged commit 3dc44f9 into main Sep 10, 2024
2 checks passed
@alaric-rd alaric-rd deleted the 50-correct-sample-value-range branch September 10, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonwo simonwo simonwo approved these changes

@rossjones rossjones rossjones approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Examples are shown from outside the data range
4 participants
@alaric-rd @rossjones @simonwo @alaricsp