Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dont pad too much #43

Merged
merged 2 commits into from
Sep 4, 2024
Merged

Dont pad too much #43

merged 2 commits into from
Sep 4, 2024

Conversation

alaric-rd
Copy link
Contributor

  • Don't ask for one more column than we have
  • While we're at it, refactor the sample padding code to try and find the bug that wasn't there, write a test to prove it wasn't there, and notice that the xlsx library uses undefined for missing values so we should too (instead of null)

simonwo
simonwo approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@simonwo simonwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, LGTM
image

@alaric-rd alaric-rd merged commit 6a8c2b9 into main Sep 4, 2024
2 checks passed
@alaric-rd alaric-rd deleted the dont-pad-too-much branch September 4, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonwo simonwo simonwo approved these changes

@rossjones rossjones Awaiting requested review from rossjones

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alaric-rd @simonwo @alaricsp