Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added feature to respect ProgressPreference setting to suppress activity indicator #34

Merged
merged 3 commits into from
Sep 13, 2023

Conversation

DailenG
Copy link
Contributor

@DailenG DailenG commented Sep 11, 2023

  • Check if PowerShell $ProgressPreference is "SilentlyContinue"
  • If true, suppress the activity indicator at Invoke-ChocoCommand

@DailenG
Copy link
Contributor Author

DailenG commented Sep 11, 2023

I've made a GUI app that utilizes ChocoMan and the activity indicator sometimes produces an individual window for each iteration of the progress characters 😂

@regg00
Copy link
Owner

regg00 commented Sep 12, 2023

Hey @DailenG
This PR is broken.
There's a missing } in the file you changed and the module is broken.
I get that message when running pretty much every commands:

Get-ChocoOutdated

ConvertFrom-Csv: C:\Users\rtlefrancois\OneDrive - Agri-Marché\Documents\GitHub\ChocoMan\Public\Get\Get-ChocoOutdated.ps1:44:42
Line |
  44 |  … ertFrom-Csv (Invoke-ChocoCommand -Arguments $Arguments).RawOutput -De …
     |                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     | Cannot validate argument on parameter 'InputObject'. The argument is null. Provide a valid value for the argument, and then try running the command again.

@regg00 regg00 added the enhancement New feature or request label Sep 12, 2023
@regg00 regg00 self-assigned this Sep 12, 2023
@DailenG
Copy link
Contributor Author

DailenG commented Sep 12, 2023

Will get this resolved today!

@regg00 regg00 merged commit cd78dc4 into regg00:main Sep 13, 2023
@regg00
Copy link
Owner

regg00 commented Sep 13, 2023

Tested and working. Thanks man.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants