docs, fix sims/tests

proto/regen/ecocredit/v1/state.proto

@@ -19,6 +19,8 @@ message CreditType {
 
  // abbreviation is a 1-3 character uppercase abbreviation of the CreditType
  // name, used in batch denominations within the CreditType. It must be unique.
+ // The letter P is reserved as the project prefix and cannot be used as a
+ // credit type to avoid confusion.
  string abbreviation = 1;
 
  // name is the name of the credit type (e.g. carbon, biodiversity).

x/ecocredit/base/simulation/msg_add_credit_type.go

@@ -49,6 +49,9 @@ func SimulateMsgAddCreditType(ak ecocredit.AccountKeeper, bk ecocredit.BankKeepe
 
  abbrev := simtypes.RandStringOfLength(r, simtypes.RandIntBetween(r, 1, 3))
  abbrev = strings.ToUpper(abbrev)
+ if abbrev == "P" { // the abbreviation "P" is reserved for projects
+ abbrev = "PP"
+ }
  name := simtypes.RandStringOfLength(r, simtypes.RandIntBetween(r, 1, 10))
 
  _, err = qryClient.CreditType(sdkCtx, &types.QueryCreditTypeRequest{

x/ecocredit/base/simulation/msg_create_batch.go

@@ -63,6 +63,7 @@ func SimulateMsgCreateBatch(ak ecocredit.AccountKeeper, bk ecocredit.BankKeeper,
  msg := &types.MsgCreateBatch{
  Issuer: issuer.Address.String(),
  ProjectId: project.Id,
+ ClassId: class.Id,
  Issuance: generateBatchIssuance(r, accs),
  StartDate: &now,
  EndDate: &tenHours,

x/ecocredit/client/testsuite/suite.go

@@ -118,6 +118,7 @@ func (s *IntegrationTestSuite) SetupSuite() {
  s.batchDenom = s.createBatch(s.val.ClientCtx, &basetypes.MsgCreateBatch{
  Issuer: s.addr1.String(),
  ProjectId: s.projectID,
+ ClassId: s.classID,
  Issuance: []*basetypes.BatchIssuance{
  {
  Recipient: s.addr1.String(),

x/ecocredit/client/testsuite/tx.go

@@ -212,6 +212,7 @@ func (s *IntegrationTestSuite) TestTxCreateBatchCmd() {
  bz, err := s.val.ClientCtx.Codec.MarshalJSON(&types.MsgCreateBatch{
  Issuer: issuer,
  ProjectId: s.projectID,
+ ClassId: s.classID,
  Issuance: []*types.BatchIssuance{
  {
  Recipient: recipient,