Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove on_scroll because it doesn't work #3977

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion reflex/components/base/app_wrap.pyi
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ class AppWrap(Fragment):
on_mouse_up: Optional[
Union[EventHandler, EventSpec, list, Callable, Var]
] = None,
on_scroll: Optional[Union[EventHandler, EventSpec, list, Callable, Var]] = None,
on_unmount: Optional[
Union[EventHandler, EventSpec, list, Callable, Var]
] = None,
Expand Down
1 change: 0 additions & 1 deletion reflex/components/base/body.pyi
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ class Body(Component):
on_mouse_up: Optional[
Union[EventHandler, EventSpec, list, Callable, Var]
] = None,
on_scroll: Optional[Union[EventHandler, EventSpec, list, Callable, Var]] = None,
on_unmount: Optional[
Union[EventHandler, EventSpec, list, Callable, Var]
] = None,
Expand Down
5 changes: 0 additions & 5 deletions reflex/components/base/document.pyi
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ class NextDocumentLib(Component):
on_mouse_up: Optional[
Union[EventHandler, EventSpec, list, Callable, Var]
] = None,
on_scroll: Optional[Union[EventHandler, EventSpec, list, Callable, Var]] = None,
on_unmount: Optional[
Union[EventHandler, EventSpec, list, Callable, Var]
] = None,
Expand Down Expand Up @@ -120,7 +119,6 @@ class Html(NextDocumentLib):
on_mouse_up: Optional[
Union[EventHandler, EventSpec, list, Callable, Var]
] = None,
on_scroll: Optional[Union[EventHandler, EventSpec, list, Callable, Var]] = None,
on_unmount: Optional[
Union[EventHandler, EventSpec, list, Callable, Var]
] = None,
Expand Down Expand Up @@ -186,7 +184,6 @@ class DocumentHead(NextDocumentLib):
on_mouse_up: Optional[
Union[EventHandler, EventSpec, list, Callable, Var]
] = None,
on_scroll: Optional[Union[EventHandler, EventSpec, list, Callable, Var]] = None,
on_unmount: Optional[
Union[EventHandler, EventSpec, list, Callable, Var]
] = None,
Expand Down Expand Up @@ -252,7 +249,6 @@ class Main(NextDocumentLib):
on_mouse_up: Optional[
Union[EventHandler, EventSpec, list, Callable, Var]
] = None,
on_scroll: Optional[Union[EventHandler, EventSpec, list, Callable, Var]] = None,
on_unmount: Optional[
Union[EventHandler, EventSpec, list, Callable, Var]
] = None,
Expand Down Expand Up @@ -318,7 +314,6 @@ class NextScript(NextDocumentLib):
on_mouse_up: Optional[
Union[EventHandler, EventSpec, list, Callable, Var]
] = None,
on_scroll: Optional[Union[EventHandler, EventSpec, list, Callable, Var]] = None,
on_unmount: Optional[
Union[EventHandler, EventSpec, list, Callable, Var]
] = None,
Expand Down
1 change: 0 additions & 1 deletion reflex/components/base/error_boundary.pyi
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ class ErrorBoundary(Component):
on_mouse_up: Optional[
Union[EventHandler, EventSpec, list, Callable, Var]
] = None,
on_scroll: Optional[Union[EventHandler, EventSpec, list, Callable, Var]] = None,
on_unmount: Optional[
Union[EventHandler, EventSpec, list, Callable, Var]
] = None,
Expand Down
1 change: 0 additions & 1 deletion reflex/components/base/fragment.pyi
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ class Fragment(Component):
on_mouse_up: Optional[
Union[EventHandler, EventSpec, list, Callable, Var]
] = None,
on_scroll: Optional[Union[EventHandler, EventSpec, list, Callable, Var]] = None,
on_unmount: Optional[
Union[EventHandler, EventSpec, list, Callable, Var]
] = None,
Expand Down
2 changes: 0 additions & 2 deletions reflex/components/base/head.pyi
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ class NextHeadLib(Component):
on_mouse_up: Optional[
Union[EventHandler, EventSpec, list, Callable, Var]
] = None,
on_scroll: Optional[Union[EventHandler, EventSpec, list, Callable, Var]] = None,
on_unmount: Optional[
Union[EventHandler, EventSpec, list, Callable, Var]
] = None,
Expand Down Expand Up @@ -119,7 +118,6 @@ class Head(NextHeadLib, MemoizationLeaf):
on_mouse_up: Optional[
Union[EventHandler, EventSpec, list, Callable, Var]
] = None,
on_scroll: Optional[Union[EventHandler, EventSpec, list, Callable, Var]] = None,
on_unmount: Optional[
Union[EventHandler, EventSpec, list, Callable, Var]
] = None,
Expand Down
2 changes: 0 additions & 2 deletions reflex/components/base/link.pyi
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ class RawLink(Component):
on_mouse_up: Optional[
Union[EventHandler, EventSpec, list, Callable, Var]
] = None,
on_scroll: Optional[Union[EventHandler, EventSpec, list, Callable, Var]] = None,
on_unmount: Optional[
Union[EventHandler, EventSpec, list, Callable, Var]
] = None,
Expand Down Expand Up @@ -130,7 +129,6 @@ class ScriptTag(Component):
on_mouse_up: Optional[
Union[EventHandler, EventSpec, list, Callable, Var]
] = None,
on_scroll: Optional[Union[EventHandler, EventSpec, list, Callable, Var]] = None,
on_unmount: Optional[
Union[EventHandler, EventSpec, list, Callable, Var]
] = None,
Expand Down
4 changes: 0 additions & 4 deletions reflex/components/base/meta.pyi
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ class Title(Component):
on_mouse_up: Optional[
Union[EventHandler, EventSpec, list, Callable, Var]
] = None,
on_scroll: Optional[Union[EventHandler, EventSpec, list, Callable, Var]] = None,
on_unmount: Optional[
Union[EventHandler, EventSpec, list, Callable, Var]
] = None,
Expand Down Expand Up @@ -125,7 +124,6 @@ class Meta(Component):
on_mouse_up: Optional[
Union[EventHandler, EventSpec, list, Callable, Var]
] = None,
on_scroll: Optional[Union[EventHandler, EventSpec, list, Callable, Var]] = None,
on_unmount: Optional[
Union[EventHandler, EventSpec, list, Callable, Var]
] = None,
Expand Down Expand Up @@ -201,7 +199,6 @@ class Description(Meta):
on_mouse_up: Optional[
Union[EventHandler, EventSpec, list, Callable, Var]
] = None,
on_scroll: Optional[Union[EventHandler, EventSpec, list, Callable, Var]] = None,
on_unmount: Optional[
Union[EventHandler, EventSpec, list, Callable, Var]
] = None,
Expand Down Expand Up @@ -277,7 +274,6 @@ class Image(Meta):
on_mouse_up: Optional[
Union[EventHandler, EventSpec, list, Callable, Var]
] = None,
on_scroll: Optional[Union[EventHandler, EventSpec, list, Callable, Var]] = None,
on_unmount: Optional[
Union[EventHandler, EventSpec, list, Callable, Var]
] = None,
Expand Down
1 change: 0 additions & 1 deletion reflex/components/base/script.pyi
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@ class Script(Component):
Union[EventHandler, EventSpec, list, Callable, Var]
] = None,
on_ready: Optional[Union[EventHandler, EventSpec, list, Callable, Var]] = None,
on_scroll: Optional[Union[EventHandler, EventSpec, list, Callable, Var]] = None,
on_unmount: Optional[
Union[EventHandler, EventSpec, list, Callable, Var]
] = None,
Expand Down
1 change: 0 additions & 1 deletion reflex/components/component.py
Original file line number Diff line number Diff line change
Expand Up @@ -604,7 +604,6 @@ def get_event_triggers(self) -> Dict[str, Any]:
EventTriggers.ON_MOUSE_OUT: lambda: [],
EventTriggers.ON_MOUSE_OVER: lambda: [],
EventTriggers.ON_MOUSE_UP: lambda: [],
EventTriggers.ON_SCROLL: lambda: [],
EventTriggers.ON_MOUNT: lambda: [],
EventTriggers.ON_UNMOUNT: lambda: [],
}
Expand Down
5 changes: 0 additions & 5 deletions reflex/components/core/banner.pyi
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,6 @@ class ConnectionToaster(Toaster):
on_mouse_up: Optional[
Union[EventHandler, EventSpec, list, Callable, Var]
] = None,
on_scroll: Optional[Union[EventHandler, EventSpec, list, Callable, Var]] = None,
on_unmount: Optional[
Union[EventHandler, EventSpec, list, Callable, Var]
] = None,
Expand Down Expand Up @@ -200,7 +199,6 @@ class ConnectionBanner(Component):
on_mouse_up: Optional[
Union[EventHandler, EventSpec, list, Callable, Var]
] = None,
on_scroll: Optional[Union[EventHandler, EventSpec, list, Callable, Var]] = None,
on_unmount: Optional[
Union[EventHandler, EventSpec, list, Callable, Var]
] = None,
Expand Down Expand Up @@ -259,7 +257,6 @@ class ConnectionModal(Component):
on_mouse_up: Optional[
Union[EventHandler, EventSpec, list, Callable, Var]
] = None,
on_scroll: Optional[Union[EventHandler, EventSpec, list, Callable, Var]] = None,
on_unmount: Optional[
Union[EventHandler, EventSpec, list, Callable, Var]
] = None,
Expand Down Expand Up @@ -319,7 +316,6 @@ class WifiOffPulse(Icon):
on_mouse_up: Optional[
Union[EventHandler, EventSpec, list, Callable, Var]
] = None,
on_scroll: Optional[Union[EventHandler, EventSpec, list, Callable, Var]] = None,
on_unmount: Optional[
Union[EventHandler, EventSpec, list, Callable, Var]
] = None,
Expand Down Expand Up @@ -412,7 +408,6 @@ class ConnectionPulser(Div):
on_mouse_up: Optional[
Union[EventHandler, EventSpec, list, Callable, Var]
] = None,
on_scroll: Optional[Union[EventHandler, EventSpec, list, Callable, Var]] = None,
on_unmount: Optional[
Union[EventHandler, EventSpec, list, Callable, Var]
] = None,
Expand Down
2 changes: 0 additions & 2 deletions reflex/components/core/client_side_routing.pyi
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ class ClientSideRouting(Component):
on_mouse_up: Optional[
Union[EventHandler, EventSpec, list, Callable, Var]
] = None,
on_scroll: Optional[Union[EventHandler, EventSpec, list, Callable, Var]] = None,
on_unmount: Optional[
Union[EventHandler, EventSpec, list, Callable, Var]
] = None,
Expand Down Expand Up @@ -126,7 +125,6 @@ class Default404Page(Component):
on_mouse_up: Optional[
Union[EventHandler, EventSpec, list, Callable, Var]
] = None,
on_scroll: Optional[Union[EventHandler, EventSpec, list, Callable, Var]] = None,
on_unmount: Optional[
Union[EventHandler, EventSpec, list, Callable, Var]
] = None,
Expand Down
1 change: 0 additions & 1 deletion reflex/components/core/clipboard.pyi
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ class Clipboard(Fragment):
Union[EventHandler, EventSpec, list, Callable, Var]
] = None,
on_paste: Optional[Union[EventHandler, EventSpec, list, Callable, Var]] = None,
on_scroll: Optional[Union[EventHandler, EventSpec, list, Callable, Var]] = None,
on_unmount: Optional[
Union[EventHandler, EventSpec, list, Callable, Var]
] = None,
Expand Down
1 change: 0 additions & 1 deletion reflex/components/core/debounce.pyi
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@ class DebounceInput(Component):
on_mouse_up: Optional[
Union[EventHandler, EventSpec, list, Callable, Var]
] = None,
on_scroll: Optional[Union[EventHandler, EventSpec, list, Callable, Var]] = None,
on_unmount: Optional[
Union[EventHandler, EventSpec, list, Callable, Var]
] = None,
Expand Down
1 change: 0 additions & 1 deletion reflex/components/core/html.pyi
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,6 @@ class Html(Div):
on_mouse_up: Optional[
Union[EventHandler, EventSpec, list, Callable, Var]
] = None,
on_scroll: Optional[Union[EventHandler, EventSpec, list, Callable, Var]] = None,
on_unmount: Optional[
Union[EventHandler, EventSpec, list, Callable, Var]
] = None,
Expand Down
4 changes: 0 additions & 4 deletions reflex/components/core/upload.pyi
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,6 @@ class UploadFilesProvider(Component):
on_mouse_up: Optional[
Union[EventHandler, EventSpec, list, Callable, Var]
] = None,
on_scroll: Optional[Union[EventHandler, EventSpec, list, Callable, Var]] = None,
on_unmount: Optional[
Union[EventHandler, EventSpec, list, Callable, Var]
] = None,
Expand Down Expand Up @@ -163,7 +162,6 @@ class Upload(MemoizationLeaf):
on_mouse_up: Optional[
Union[EventHandler, EventSpec, list, Callable, Var]
] = None,
on_scroll: Optional[Union[EventHandler, EventSpec, list, Callable, Var]] = None,
on_unmount: Optional[
Union[EventHandler, EventSpec, list, Callable, Var]
] = None,
Expand Down Expand Up @@ -248,7 +246,6 @@ class StyledUpload(Upload):
on_mouse_up: Optional[
Union[EventHandler, EventSpec, list, Callable, Var]
] = None,
on_scroll: Optional[Union[EventHandler, EventSpec, list, Callable, Var]] = None,
on_unmount: Optional[
Union[EventHandler, EventSpec, list, Callable, Var]
] = None,
Expand Down Expand Up @@ -333,7 +330,6 @@ class UploadNamespace(ComponentNamespace):
on_mouse_up: Optional[
Union[EventHandler, EventSpec, list, Callable, Var]
] = None,
on_scroll: Optional[Union[EventHandler, EventSpec, list, Callable, Var]] = None,
on_unmount: Optional[
Union[EventHandler, EventSpec, list, Callable, Var]
] = None,
Expand Down
2 changes: 0 additions & 2 deletions reflex/components/datadisplay/code.pyi
Original file line number Diff line number Diff line change
Expand Up @@ -965,7 +965,6 @@ class CodeBlock(Component):
on_mouse_up: Optional[
Union[EventHandler, EventSpec, list, Callable, Var]
] = None,
on_scroll: Optional[Union[EventHandler, EventSpec, list, Callable, Var]] = None,
on_unmount: Optional[
Union[EventHandler, EventSpec, list, Callable, Var]
] = None,
Expand Down Expand Up @@ -1671,7 +1670,6 @@ class CodeblockNamespace(ComponentNamespace):
on_mouse_up: Optional[
Union[EventHandler, EventSpec, list, Callable, Var]
] = None,
on_scroll: Optional[Union[EventHandler, EventSpec, list, Callable, Var]] = None,
on_unmount: Optional[
Union[EventHandler, EventSpec, list, Callable, Var]
] = None,
Expand Down
1 change: 0 additions & 1 deletion reflex/components/datadisplay/dataeditor.pyi
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,6 @@ class DataEditor(NoSSRComponent):
on_row_appended: Optional[
Union[EventHandler, EventSpec, list, Callable, Var]
] = None,
on_scroll: Optional[Union[EventHandler, EventSpec, list, Callable, Var]] = None,
on_selection_cleared: Optional[
Union[EventHandler, EventSpec, list, Callable, Var]
] = None,
Expand Down
1 change: 0 additions & 1 deletion reflex/components/el/element.pyi
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ class Element(Component):
on_mouse_up: Optional[
Union[EventHandler, EventSpec, list, Callable, Var]
] = None,
on_scroll: Optional[Union[EventHandler, EventSpec, list, Callable, Var]] = None,
on_unmount: Optional[
Union[EventHandler, EventSpec, list, Callable, Var]
] = None,
Expand Down
1 change: 0 additions & 1 deletion reflex/components/el/elements/base.pyi
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@ class BaseHTML(Element):
on_mouse_up: Optional[
Union[EventHandler, EventSpec, list, Callable, Var]
] = None,
on_scroll: Optional[Union[EventHandler, EventSpec, list, Callable, Var]] = None,
on_unmount: Optional[
Union[EventHandler, EventSpec, list, Callable, Var]
] = None,
Expand Down
Loading
Loading