You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Have you followed the guidelines stated in CONTRIBUTING.md file?
Have you checked to ensure there aren't any other open Pull Requests for the desired changed?
Type of change
Please delete options that are not relevant.
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update
New Feature Submission:
Does your submission pass the tests?
Have you linted your code locally prior to submission?
Changes To Core Features:
Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your core changes, as applicable?
Have you successfully ran tests with your changes locally?
After these steps, you're ready to open a pull request.
Description
Added a fill_color property to update the background style of the fill in progress bar. Since we do not expose the Progress.Root and Progress.Indicator components of radix ui. I updated the indicator class directly.
I unfortunetly dont have the .pyi_generator_last_run and thus generating the pyi will cause issue for me
I tested locally to delete .pyi_generator_last_run and running python3 scripts/make_pyi.py reflex/components/radix/themes/components/progress.py worked without issue.
I unfortunetly dont have the .pyi_generator_last_run and thus generating the pyi will cause issue for me
I tested locally to delete .pyi_generator_last_run and running python3 scripts/make_pyi.py reflex/components/radix/themes/components/progress.py worked without issue.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Submissions:
Type of change
Please delete options that are not relevant.
New Feature Submission:
Changes To Core Features:
After these steps, you're ready to open a pull request.
Description
Added a fill_color property to update the background style of the fill in progress bar. Since we do not expose the Progress.Root and Progress.Indicator components of radix ui. I updated the indicator class directly.