Minify state names v2 #3728
Minify state names v2 #3728
Conversation
|
Actually, it's not a problem with the env vars not getting passed. Tests are failing due to |
benedikt-bartscher
force-pushed
the
minify-state-names-v2
branch
from
b9c852e
to
bf6ec96
Compare
@masenf do you have any idea how to solve this? |
| @@ -23,6 +23,8 @@ export const clientStorage = {{ client_storage|json_dumps }} | |||
| export const clientStorage = {} | |||
| {% endif %} | |||
|
|
|||
| export const main_state_name = "{{const.main_state_name}}" | |||
There was a problem hiding this comment.
I think this is already coming in as state_name.
reflex/compiler/compiler.py:90
There was a problem hiding this comment.
iirc this was the state name for rx.app.App.state. will check
There was a problem hiding this comment.
Yes, they are not the same. compile_contexts gets called from reflex.app.App._compile with self.state
There was a problem hiding this comment.
maybe for clarity, we should call the var root_state_name instead of main_state_name just to indicate that it's the name of rx.State, the root of the state "tree"
There was a problem hiding this comment.
What about main_state_dispatch should we rename that one to root_state_dispatch as well?
Thanks, i was thinking about that. Do you want me to migrate to state refs in this PR or in a followup? |
|
i think you can do the refs in this PR, as long as it's not too invasive. We have a big Var refactor coming in the next week or so, that might conflict, but we can fix that up |
alternative to #3701
currently the new tests are failing because somehow the env vars i was trying to set (in the fixtures) do not persist or do not get passed to frontend and backend correctly