Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Benchmark with app harness #2774

Merged
merged 61 commits into from
Mar 13, 2024
Merged

Benchmark with app harness #2774

merged 61 commits into from
Mar 13, 2024

Conversation

ElijahAhianyo
Copy link
Collaborator

@ElijahAhianyo ElijahAhianyo commented Mar 4, 2024 •
edited
Loading

Summary

  • Add pytest benchmark on top of app harness test to generate stats on small/medium sized apps in CI.
  • CI is run on linux/Mac/Windows for supported python major+minor versions and pushed to new table on RDB.

Tests

  • new benchmark tests pushed results to RDB
    image

ElijahAhianyo and others added 30 commits March 4, 2024 15:00
@martinxu9 martinxu9 marked this pull request as ready for review March 6, 2024 04:27
@martinxu9 martinxu9 requested a review from Alek99 March 6, 2024 04:27
masenf
masenf requested changes Mar 11, 2024
View reviewed changes
Copy link
Collaborator

@masenf masenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace "Test that background tasks work as expected." with the actual description.

benchmarks/test_benchmark_compile_components.py Outdated Show resolved Hide resolved
benchmarks/test_benchmark_compile_components.py Outdated Show resolved Hide resolved
@ElijahAhianyo
Copy link
Collaborator Author

Replace "Test that background tasks work as expected." with the actual description.

Fixed 😅

@picklelo picklelo merged commit a06b570 into main Mar 13, 2024
60 checks passed
@masenf masenf deleted the elijah/benchmark branch April 24, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masenf masenf masenf approved these changes

@picklelo picklelo Awaiting requested review from picklelo

@Alek99 Alek99 Awaiting requested review from Alek99

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ElijahAhianyo @masenf @picklelo @martinxu9