Skip to content

Commit

Permalink
use serializer before serializing base yourself (#3960)
Browse files Browse the repository at this point in the history
  • Loading branch information
adhami3310 authored Sep 20, 2024
1 parent bca49d3 commit a5d7365
Showing 1 changed file with 14 additions and 14 deletions.
28 changes: 14 additions & 14 deletions reflex/vars/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -1074,6 +1074,20 @@ def create(
if isinstance(value, EventHandler):
return Var(_js_expr=".".join(filter(None, get_event_handler_parts(value))))

serialized_value = serializers.serialize(value)
if serialized_value is not None:
if isinstance(serialized_value, dict):
return LiteralObjectVar.create(
serialized_value,
_var_type=type(value),
_var_data=_var_data,
)
if isinstance(serialized_value, str):
return LiteralStringVar.create(
serialized_value, _var_type=type(value), _var_data=_var_data
)
return LiteralVar.create(serialized_value, _var_data=_var_data)

if isinstance(value, Base):
# get the fields of the pydantic class
fields = value.__fields__.keys()
Expand All @@ -1089,20 +1103,6 @@ def create(
_var_data=_var_data,
)

serialized_value = serializers.serialize(value)
if serialized_value is not None:
if isinstance(serialized_value, dict):
return LiteralObjectVar.create(
serialized_value,
_var_type=type(value),
_var_data=_var_data,
)
if isinstance(serialized_value, str):
return LiteralStringVar.create(
serialized_value, _var_type=type(value), _var_data=_var_data
)
return LiteralVar.create(serialized_value, _var_data=_var_data)

if dataclasses.is_dataclass(value) and not isinstance(value, type):
return LiteralObjectVar.create(
{
Expand Down

0 comments on commit a5d7365

Please sign in to comment.