Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix slug on save (Closes GH-485) #508

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

brigriffin
Copy link

Also encountering the annoying issue #485 where slugs are not generated and seeing that finally no one created a PR for it I decided to submit this one so things can get finally fixed. Credits go here to @imunteanu and @spotlessicode. A test covering this specific case should also already be available here I believe:

describe "#should_generate_new_friendly_id?" do

Thanks in advance for reviewing this PR.

@brigriffin
Copy link
Author

Any chance someone could take a look at my PR?

I also submitted recently issue #509 because the CI pipeline seems to be broken for this repo.

Let me know if there is anything I can help with. Thanks in advance for your time.

@kjoscha
Copy link

kjoscha commented Apr 16, 2019

Changing the method in our refinery app does raise a "stack level too deep" on validarion in case of missing attributes.
I wonder if you can reproduce it by a manual test. Just keep title or body of a post blank.

@brigriffin
Copy link
Author

brigriffin commented Apr 16, 2019

@kjoscha I can't reproduce this issue manually on my test installation. If I leave either the title or the body of a blog post empty I get respectively:

  • Title can't be blank
  • Body can't be blank

Which version of RefineryCMS are you using? and which version of Rails?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants