Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when clicking on 'save & continue' then changing locale #487

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cedrtang
Copy link

@cedrtang cedrtang commented Jun 8, 2018

I noticed a bug when using different locales and saving using the "Save & continue editing" button: the URL of the locales switch picker got undefined and an error occur.

The fix is to apply the same behavior as Pages in Refinery using the JS function 'submit_and_continue' in admin.js.erb that changes the locale switch picker URL. If we send back the correct URL parameters after a Post update, it works correctly.

@bricesanchez
Copy link
Member

Thanks for your contribution!

Could you add a test to confirm your bugfix?

@cedrtang
Copy link
Author

cedrtang commented Jun 8, 2018

@bricesanchez Sure, no problem. It does require javascript in the capybara test to run correctly. Which js driver do you run in your CI environment?

@parndt
Copy link
Member

parndt commented Jul 9, 2018

@cedrtang we're using the Poltergeist gem, so phantomjs

@bricesanchez
Copy link
Member

We are now using Chrome headless :D
refinery/refinerycms#3394

@TonhaoSantos
Copy link

Hi, I'm having this problem.
Include the blog today and I came across this URL failure

captura de tela de 2018-11-06 18-31-53

By hovering over the "Producto" menu option, the link is wrong.
Even clicking "save" and not "save & continue" to save the page the error continues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants