Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing show-whitespace #18

Draft
wants to merge 2 commits into
base: default-a
Choose a base branch
from
Draft

Testing show-whitespace #18

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a4e66d
Update README.md
fregante Jun 20, 2022
d773f59
More spaces
fregante Jun 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ Rules:
1. I open an issue named `Testing in-title #1 issue references`
Copy link
Member Author

@fregante fregante Jun 20, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spaces

 
  
  function() {}  
function  () {}

 
  
  function() {}  
function  () {}

Tabs

	
		
		function()	{}		
function		()	{}

	
		
		function()	{}		
function		()	{}

Mixed

	 
	 	 
 	 function() {} 	
function	 ()	{}

	 
	 	 
 	 function() {} 	
function	 ()	{}

Inlined

sandbox/README.md

Lines 19 to 28 in d773f59

```md
function() {}
function () {}
# Test URLs
https://github.com/fregante/github-sandbox/issues/345
```

Real code

function showWhiteSpacesOn(line: Element): void {
	const shouldAvoidSurroundingSpaces = Boolean(line.closest('.blob-wrapper-embedded')); // #2285
	const textNodesOnThisLine = getTextNodes(line);
	for (const [nodeIndex, textNode] of textNodesOnThisLine.entries()) {
		// `textContent` reads must be cached #2737
		let text = textNode.textContent!;
		if (text.length > 1000) { // #5092
			continue;
		}

3. I use its URL in a PR, like:
```md
I created this feature that works on titles.
I created this feature that works on titles.
fregante marked this conversation as resolved.
Show resolved Hide resolved

# Test URLs

Expand Down