Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(web): add dockerfiles #89
chore(web): add dockerfiles #89
Changes from all commits
d4659eb
023c1c0
3c5e5fd
146a6c3
829e89d
710bcd2
742f60d
ed5a6e4
5644baa
a09045f
3e60a78
94ccdcb
190efdf
1feed3b
2c2af73
c5aabb0
8cecec3
d1c05a1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix shell script security issues
Unquoted variables in Docker commands could lead to word splitting or command injection issues.
Apply this fix:
📝 Committable suggestion
🧰 Tools
🪛 actionlint (1.7.3)
26-26: shellcheck reported issue in this script: SC2086:info:2:17: Double quote to prevent globbing and word splitting
(shellcheck)
26-26: shellcheck reported issue in this script: SC2086:info:3:13: Double quote to prevent globbing and word splitting
(shellcheck)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
Missing health check endpoint and port configuration needs attention
The verification reveals important deployment prerequisites that need to be addressed:
Required actions:
/health
or/healthz
)EXPOSE 8080
to the server's Dockerfile to explicitly document the port configuration🔗 Analysis chain
Verify deployment prerequisites
Before deploying, please verify:
Also applies to: 77-81
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
Length of output: 229
Script:
Length of output: 2798
Script:
Length of output: 2851
🧰 Tools
🪛 actionlint (1.7.3)
31-31: shellcheck reported issue in this script: SC2086:info:2:11: Double quote to prevent globbing and word splitting
(shellcheck)
31-31: shellcheck reported issue in this script: SC2086:info:3:12: Double quote to prevent globbing and word splitting
(shellcheck)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix variable inconsistency and enhance deployment configuration
Multiple issues need to be addressed in the server deployment section:
Apply these fixes:
🧰 Tools
🪛 actionlint (1.7.3)
76-76: shellcheck reported issue in this script: SC2086:info:2:11: Double quote to prevent globbing and word splitting
(shellcheck)
76-76: shellcheck reported issue in this script: SC2086:info:3:12: Double quote to prevent globbing and word splitting
(shellcheck)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update deprecated GitHub Actions commands and improve shell script
set-output
command is deprecated. UseGITHUB_OUTPUT
instead.Apply these changes:
📝 Committable suggestion
🧰 Tools
🪛 actionlint
32-32: shellcheck reported issue in this script: SC2236:style:4:9: Use -n instead of ! -z
(shellcheck)
32-32: workflow command "set-output" was deprecated. use
echo "{name}={value}" >> $GITHUB_OUTPUT
instead: https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions(deprecated-commands)
32-32: workflow command "set-output" was deprecated. use
echo "{name}={value}" >> $GITHUB_OUTPUT
instead: https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions(deprecated-commands)
32-32: workflow command "set-output" was deprecated. use
echo "{name}={value}" >> $GITHUB_OUTPUT
instead: https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions(deprecated-commands)
32-32: workflow command "set-output" was deprecated. use
echo "{name}={value}" >> $GITHUB_OUTPUT
instead: https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions(deprecated-commands)
32-32: workflow command "set-output" was deprecated. use
echo "{name}={value}" >> $GITHUB_OUTPUT
instead: https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions(deprecated-commands)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix incorrect output variable reference
The environment variable TAG is referencing a non-existent output variable 'tag_short'.
📝 Committable suggestion
🧰 Tools
🪛 actionlint (1.7.3)
76-76: property "tag_short" is not defined in object type {name: string; new_tag: string; new_tag_short: string; sha_short: string}
(expression)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix incorrect tags parameter in docker/build-push-action
The tags parameter is using new_tag_short instead of the tags output from the options step.
📝 Committable suggestion