Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some accessibility to the react-json-tree for keyboard naviagation, also allow Arrow Override #1747

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

tisdadd
Copy link

@tisdadd tisdadd commented Sep 3, 2024

This library had met everything I needed but for the fact that I wanted things to be able to be navigated by keyboards. Default arrows are now focusable as buttons and have some basic aria expandable applied. Looked into treeitem roles but realized that they are explicitly set for a selectable tree inputs, so treated it as standard expandable list.

I saw Issue 464 when I was initially looking simply into replacing with buttons, and realized that I should probably still throw that in there.

Hopefully this is helpful, if not or if I should do something else, please let me know.

Copy link

changeset-bot bot commented Sep 3, 2024

🦋 Changeset detected

Latest commit: bfa9c3f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 17 packages
Name Type
react-json-tree Minor
react-json-tree-example Minor
remotedev-redux-devtools-extension Patch
@redux-devtools/inspector-monitor Patch
@redux-devtools/log-monitor Patch
@redux-devtools/rtk-query-monitor Patch
@redux-devtools/app-core Patch
@redux-devtools/inspector-monitor-test-tab Patch
@redux-devtools/inspector-monitor-trace-tab Patch
inspector-demo Patch
test-demo Patch
counter-redux Patch
todomvc Patch
slider-todomvc Patch
rtk-query-demo Patch
@redux-devtools/app Patch
@redux-devtools/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant