Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable lock button for non-Redux connections. #1658

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

EskiMojo14
Copy link

Currently the lock button is disabled if the app doesn't think it's talking to a Redux store - which is decided here:

if (type === 'STATE') lib = 'redux';

There doesn't seem to be a reason stated for this, and stores other than Redux can certainly implement locking, so I think it would be good to enable this. It's still hidden based on the feature option, which defaults to only being true if it's a Redux store:

Copy link

changeset-bot bot commented May 6, 2024

🦋 Changeset detected

Latest commit: 136ce3e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@redux-devtools/app Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

@faiyun123 faiyun123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants