Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds argument to prevent Redux DevTool CLI disconnecting when debugging #1622

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

jardicc
Copy link

@jardicc jardicc commented Mar 4, 2024

Adds new CLI argument to change pingTimeout value. This solves few issues for me if I set crazy high number.

  1. UXP in Photoshop has UWP implementation of WebSockets and its client when asked to send empty message it is never sent but everything else is. Thefore it gets disconnected. examples not working in @redux-devtools/remote  #1614

  2. I think for some older middleware using protocol V1 sending different ping content this could help as well It works few seconds but socket hangs up with code 4001 zalmoxisus/remote-redux-devtools#158

  3. When you debug client app and you stop on breakpoint for 20s which default value of socket cluster... it will disconnect debugger as well because you stopped client app so it can't send a ping. So value can be increased to prevent that.

Also maxRequestBody was wrong.

Please let me know if I should change something or feel free to change it yourself. I was thinking about seconds instead of ms but not sure what is better.

Copy link

changeset-bot bot commented Mar 4, 2024

⚠️ No Changeset found

Latest commit: ef3f1c5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jardicc
Copy link
Author

jardicc commented Sep 6, 2024

Can someone please review this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant